Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Generic actions to raise if they don't have return type but have an return value #1805

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Generic actions to raise if they don't have return type but have an return value #1805

merged 2 commits into from
Feb 20, 2025

Conversation

jechol
Copy link
Contributor

@jechol jechol commented Feb 19, 2025

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel
Copy link
Contributor

Use this Ash.Error.Framework.InvalidReturnType exception, i.e raise Ash.Error.Framework.InvalidReturnType, message: ... 🙇

@jechol
Copy link
Contributor Author

jechol commented Feb 20, 2025

Use this Ash.Error.Framework.InvalidReturnType exception, i.e raise Ash.Error.Framework.InvalidReturnType, message: ... 🙇

Done. Additionally, I renamed raise_invalid_manual_action_return to raise_invalid_generic_action_return.

@zachdaniel zachdaniel merged commit 0949580 into ash-project:main Feb 20, 2025
36 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jechol @zachdaniel