convert sbcs codec and some tests #255
Conversation
|
The test failures seem to be from the stuff in master and are not related to my PR |
ashtuchkin
force-pushed
the
master
branch
2 times, most recently
from
84ee650 to
9aa082f
Compare
| newBuf[idx2] = decodeBuf[idx1]; | ||
| newBuf[idx2+1] = decodeBuf[idx1+1]; | ||
| for (let i = 0; i < str.length; i++) | ||
| bytes[i] = this.encodeBuf[str.charCodeAt(i)]; |
There was a problem hiding this comment.
The funny part is, I was expecting the the whole migration will be more like a manual labor. Just changing calls to Buffer.from and Buffer.toString to our custom functions. So it took me some time to figure out how change the code. But in the end was interesting to dig a little bit deeper into encodings business.
|
Looks like the master is green now, so could you rebase and I'll merge tomorrow. |
|
@ashtuchkin rebased on master. All green now. |
|
Thank you! |
|
@ashtuchkin this is great news! I was missing prettier in the workflow very much :) Which codec do you think would be better for me to take? Probably in my case better == simpler to migrate. |
|
Utf32 or dbcs would be next I guess. Both will require some diving into, so
I'd understand if you wouldn't want to spend more time than you planned on
it.
…On Sat, Jul 18, 2020, 00:00 Fedor Nezhivoi ***@***.***> wrote:
@ashtuchkin <https://github.com/ashtuchkin> this is great news! I was
missing prettier in the workflow very much :)
Which codec do you think would be better for me to take? Probably in my
case better == simplier to migrate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZKHNJUSVOPRFMUIRVCBLR4EM5TANCNFSM4O3IWYEQ>
.
|
Here is the update for SBCS.
My only problem is - I am not sure how to convert
sbcs-test.jsbecause it usesiconvand I am not sure what to do with some usages ofBufferthere. Maybe it'd be better for you to take a look at this suite?Otherwise I think everything is there.