Adding default deadline of 10 minutes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd replication requests
Current coverage is 74.18% (diff: 0.00%)@@ master #62 diff @@
==========================================
Files 29 29
Lines 519 519
Methods 0 0
Messages 0 0
Branches 86 86
==========================================
Hits 385 385
Misses 80 80
Partials 54 54
|
|
LGTM |
gsriram7
approved these changes
Dec 17, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding default deadline of 10 minutes for all forward and replication requests. Without this - sometimes the forward or replicate call gets stuck for infinite amount of time. This has caused havoc on production for a while now - while this is not the actual culprit to the problem this should help us move forward by re-trying after sometime.