Refactoring Cluster support in suuchi #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added typesafe config dependency on suuchi-core - Fixing Atomix cluster implementation + Added ClusterProvider for Atomix cluster - Compiling the whole project still on 1.7 but Atomix alone to 1.8 - Improving the README on Atomix implementation - ClusterProvider#createCluster now takes typesafe Config as a param so we can pass around additional settings to cluster implementations.
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
============================================
+ Coverage 73.65% 74.17% +0.51%
- Complexity 115 121 +6
============================================
Files 33 34 +1
Lines 577 604 +27
Branches 74 78 +4
============================================
+ Hits 425 448 +23
- Misses 90 91 +1
- Partials 62 65 +3 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing both the atomix + scalecube implementations. We don't have cluster integrated into Server yet, but this is baby steps towards it.