fix Orthographic Picking #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul2t
force-pushed
the
orthographic-picking
branch
from
e70c385
to
1320af8
Compare
|
Thanks for the contribution 🙏 I've changed it so it's not calculating screen2ray two times which might affect performance. What do you think? And is it still working in your case? |
|
I knew there was something to be done to avoid that, but didn't take the time to figure it out. |
|
Perfect, thanks for testing 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the 3d picking with an orthographic 3d camera.
It was working in top view, which is why it was working in the case of a 2d camera.
This change seems to be fixing the picking for any 3d orthographic camera.
This is using : https://stackoverflow.com/questions/7692988/opengl-math-projecting-screen-space-to-world-space-coords
I'm not sure how this can be factorized with the Perspective screen2ray.