preserve user-specified report source instead of config default #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The report_source parameter was being incorrectly overridden by the config default value due to Python's 'or' operator behavior with truthy values. Changed the logic to explicitly check for the passed parameter first before falling back to config values.
Using None as default allows for proper validation of unspecified sources and follows the principle of explicit configuration.
|
I tested the change and it worked. ie when using the nextjs ( port 3000 ) interface my preferences selection for report source My Documents ( local ) was respected |
Add more descriptive logging statements when loading and processing local documents: count of loaded documents
|
Cool. Just added some logging for Local mode in the last commit |
assafelovic
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
This is super helpful and important bug fix thank you @alesaccoia !
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report_source parameter was being incorrectly overridden by the config default value due to Python's 'or' operator behavior with truthy values. Changed the logic to explicitly check for the passed parameter first before falling back to config values.