-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice.
Are there any possible complications or issues with using workers that we should test for?
Trying to think of edge cases like bundling the same bundle several times, multiple bundlings simultaneously etc.
Theres probably not super much so long as we trust jest-worker
and its test coverage.
package.json
Outdated
@@ -38,6 +38,7 @@ | |||
"convict": "^4.0.1", | |||
"cors": "^2.8.4", | |||
"express": "^4.16.2", | |||
"jest-worker": "^21.3.0-beta.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22.0.0 is coming any day now, will hold on merging until then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No code difference, I just dislike beta dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be a code difference, actually: jestjs/jest#5068
We still |
JIRA Issue
COREWEB-41
Status
READY
Description
We want to offload bundling to another thread/process to not lock up resources on potentially CPU heavy work.
As we use promises,
worker-farm
is not an option (it only supports callbacks), so I chose to go withjest-worker
, which is what runs Jest tests in parallel.I have not added new tests, as the observable behaviour is identical, beyond some extra needed cleanup work. We don't have programmatic API documented in the README, perhaps we should?
Todos
Deploy Notes
N/A
Related PRs