Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add discord dep #25

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Add discord dep #25

merged 2 commits into from
Aug 5, 2023

Conversation

astariul
Copy link
Owner

@astariul astariul commented Aug 5, 2023

🔍️ Description

Note that adding this dependency is not necessary, because the code in discord_interactive package doesn't use discord.py directly.

However it is dependent on it, so if there is a breaking change in discord.py, most likely discord_interactive will not work as a result. For this reason, I'm adding discord.py as a direct dependency of discord_interactive, I believe it will make it easier to manage dependencies and versions.

🧐 Context

After major release of discord.py, the example code in this repository would (seemingly randomly) stop working. By fixing the dependency to a fixed version, we ensure it works for this version, and ensure we need to test newly released version of discord.py.

⚠️ Side-effects / Shortcomings

✅ How this was tested ?

🌱 Checklist

  • Perform self-review of my own code
  • Comment the code, particularly in hard-to-understand areas
  • Update the documentation accordingly to the new code
  • Lint / format the code

@astariul astariul self-assigned this Aug 5, 2023
@astariul astariul merged commit 7d4da05 into main Aug 5, 2023
@astariul astariul deleted the add_discord_deps branch August 5, 2023 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant