Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added KI-I plugins for EasyReading project: Plugin Help to be updated #339

Merged
merged 2 commits into from
May 6, 2020

Conversation

deinhofer
Copy link
Contributor

@kingcole Thanks for the contribution.
Please update the respective .md files in Documentation/docs/plugins/processors/
Please also a sample model to ARE/models/useCases/ or componentTests

Is there any special HW needed? How to set it up and configure it? maybe put this info to the main plugins.

@deinhofer deinhofer requested a review from kingcole May 6, 2020 08:30
…ntation for plugins: BlinkChangeDetector, DateToDouble, HRVRmssdFromRR, JsonParser, StringExtractor, TimestampWriter.
@sabicalija
Copy link
Contributor

I've copied the documentation from the PDF and transformed it to markdown.

What's missing are pictures for each plugin. Do we have some already?

I've added all plugins (BlinkChangeDetector, DateToDouble, HRVRmssdFromRR, JsonParser, StringExtractor, TimestampWriter) to subcategory "Easy Reading". Hope that's fine. If not, please correct it.

@sabicalija
Copy link
Contributor

I wasn't sure about where to put "Used for blink rate...". Does it belong to the paragraph before or afterward?

image

@deinhofer
Copy link
Contributor Author

@sabicalija Thanks for converting the help-files. I will merge now.
@kingcole You can update the markdown after merging as well directly in the master branch.

@deinhofer deinhofer merged commit 8584681 into master May 6, 2020
@deinhofer deinhofer deleted the ki-i/easyreading-plugins branch May 6, 2020 18:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants