Remove awful big if else satement.

asterjdm · Aug 3, 2024 · 0af52f1 · 0af52f1
1 parent c51fb11
commit 0af52f1
Showing 1 changed file with 17 additions and 18 deletions.
diff --git a/api/utils/getClientIp.php b/api/utils/getClientIp.php
@@ -1,21 +1,20 @@
 <?php
 function getClientIp() {
-    $ipaddress = '';
-    if (isset($_SERVER['HTTP_CLIENT_IP']))
-        $ipaddress = $_SERVER['HTTP_CLIENT_IP'];
-    else if(isset($_SERVER['HTTP_X_FORWARDED_FOR']))
-        $ipaddress = $_SERVER['HTTP_X_FORWARDED_FOR'];
-    else if(isset($_SERVER['HTTP_X_FORWARDED']))
-        $ipaddress = $_SERVER['HTTP_X_FORWARDED'];
-    else if(isset($_SERVER['HTTP_FORWARDED_FOR']))
-        $ipaddress = $_SERVER['HTTP_FORWARDED_FOR'];
-    else if(isset($_SERVER['HTTP_FORWARDED']))
-        $ipaddress = $_SERVER['HTTP_FORWARDED'];
-    else if(isset($_SERVER['REMOTE_ADDR']))
-        $ipaddress = $_SERVER['REMOTE_ADDR'];
-    else
-        $ipaddress = 'UNKNOWN';
-    return $ipaddress;
-}
+    $headers = [
+        'HTTP_CLIENT_IP', 
+        'HTTP_X_FORWARDED_FOR', 
+        'HTTP_X_FORWARDED', 
+        'HTTP_FORWARDED_FOR', 
+        'HTTP_FORWARDED', 
+        'REMOTE_ADDR'
+    ];
+
+    foreach ($headers as $header) {
+        if (isset($_SERVER[$header])) {
+            return $_SERVER[$header];
+        }
+    }
 
-?>
+    return 'UNKNOWN';
+}
+?>