Skip to content

Populate CXX during builds to avoid calling the system toolchain #545

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Feb 27, 2025

Closes #512

@zanieb
Copy link
Member Author

zanieb commented Feb 27, 2025

Concretely, it seems like this means that libffi was previously built using g++ / Apple clang on macOS and now it'll use our LLVM toolchain as intended.

@zanieb
Copy link
Member Author

zanieb commented Feb 27, 2025

We may just want to define target_cxx everywhere instead of falling back to host_cxx.

@zanieb zanieb requested review from geofft and indygreg February 27, 2025 21:48
Copy link
Collaborator

@geofft geofft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Mildly unhinged idea - I wonder if we can use the Mac's Seatbelt sandboxing system to allowlist executables from the system to protect against things like this.

@zanieb zanieb merged commit d0ed97f into main Mar 5, 2025
330 checks passed
@zanieb zanieb deleted the zb/fix-cxx branch March 5, 2025 19:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly non-isolated build on macOS
2 participants