add binop early return

astral-sh · Oct 30, 2024 · 026ee0b · 026ee0b
1 parent 8a10fd5
commit 026ee0b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/pyupgrade/UP044.py b/crates/ruff_linter/resources/test/fixtures/pyupgrade/UP044.py
@@ -9,3 +9,5 @@ class D(Generic[Unpack  [Shape]]):
     pass
 
 def f(*args: Unpack[tuple[int, ...]]): pass
+
+def foo(*args: Unpack[int | str]) -> None: pass  # not supported
diff --git a/crates/ruff_linter/src/rules/pyupgrade/rules/use_pep646_unpack.rs b/crates/ruff_linter/src/rules/pyupgrade/rules/use_pep646_unpack.rs
@@ -69,6 +69,11 @@ pub(crate) fn use_pep646_unpack(checker: &mut Checker, expr: &ExprSubscript) {
         return;
     }
 
+    if slice.is_bin_op_expr() {
+        // fixing this would introduce a syntax error
+        return;
+    }
+
     let mut diagnostic = Diagnostic::new(NonPEP646Unpack, *range);
 
     let inner = checker.locator().slice(slice.as_ref());

diff --git a/...rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__unpack_pep_646_py311.snap b/...rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__unpack_pep_646_py311.snap
@@ -47,6 +47,8 @@ UP044.py:11:14: UP044 [*] Use `*` for unpacking
 10 | 
 11 | def f(*args: Unpack[tuple[int, ...]]): pass
    |              ^^^^^^^^^^^^^^^^^^^^^^^ UP044
+12 | 
+13 | def foo(*args: Unpack[int | str]) -> None: pass  # not supported
    |
    = help: Convert to `*` for unpacking
 
@@ -56,3 +58,5 @@ UP044.py:11:14: UP044 [*] Use `*` for unpacking
 10 10 | 
 11    |-def f(*args: Unpack[tuple[int, ...]]): pass
    11 |+def f(*args: *tuple[int, ...]): pass
+12 12 | 
+13 13 | def foo(*args: Unpack[int | str]) -> None: pass  # not supported