Allow © in copyright notices #10065
Merged
Allow © in copyright notices #10065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/cpy
branch
from
431bc8b
to
a88a8ed
Compare
charliermarsh
force-pushed
the
charlie/cpy
branch
from
a88a8ed
to
3b49221
Compare
|
|
@BurntSushi - Is there a cost to making the pattern non-ASCII here? |
BurntSushi
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM. It is rather unlikely that this introduces any additional cost. Since the regex starts with a literal (even though it's case insensitive), this is probably getting optimized via a nice prefix prefilter. The best kind. What comes after won't matter much, and the regex is already matching non-ASCII things. For example, \d matches 𝟜.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10061.