ruff server refreshes diagnostics for open files when file configuration is changed
#10988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MichaReiser
approved these changes
Apr 17, 2024
crates/ruff_server/src/server/api/notifications/did_change_watched_files.rs
Show resolved
Hide resolved
|
It would be nice to have integration tests for this :P |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The server now requests a workspace diagnostic refresh when a configuration file gets changed. This means that diagnostics for all open files will be automatically re-requested by the client on a config change.
Test Plan
You can test this by opening several files in VS Code, setting
selectin your file configuration to[], and observing that the diagnostics go away once the file is saved (besides anyPylancediagnostics). Restore it to what it was before, and you should see the diagnostics automatically return once a save happens.