ruff server
respects per-file-ignores
configuration
#11224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11185
Fixes #11214
Document path and package information is now forwarded to the Ruff linter, which allows
per-file-ignores
to correctly match against the file name. This also fixes an issue where the import sorting rule didn't distinguish between third-party and first-party packages since we didn't pass in the package root.Test Plan
per-file-ignores
should ignore files as expected. One quick way to check is by adding this to yourpyproject.toml
:Then, confirm that no diagnostics appear when you add code to an
__init__.py
file (besides syntax errors).The import sorting fix can be verified by failing to reproduce the original issue - an
I001
diagnostic should not appear inother_module.py
.