Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[flake8-bugbear] Allow singleton tuples with starred expressions in B013 #12484

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jul 24, 2024

Summary

Closes #12450. Reverts previous attempt at handling starred expressions introduced in #7080 - replacing this approach by simply allowing such expressions.

Test Plan

  • Added bug case to test fixture
  • Cargo test

Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #12484 will improve performances by 4.26%

Comparing dylwil3:bug/unpacking-tuple-exceptions (2d4a9ab) with main (8659f2f)

Summary

⚡ 1 improvements
✅ 32 untouched benchmarks

Benchmarks breakdown

Benchmark main dylwil3:bug/unpacking-tuple-exceptions Change
lexer[numpy/globals.py] 30.4 µs 29.2 µs +4.26%

@MichaReiser

This comment was marked as outdated.

@MichaReiser
Copy link
Member

Whoopps. I think I mixed up the PRs.

@MichaReiser MichaReiser added the bug Something isn't working label Jul 24, 2024
@MichaReiser
Copy link
Member

Thanks. This looks good to me.

@MichaReiser MichaReiser merged commit 8890735 into astral-sh:main Jul 24, 2024
20 checks passed
@dylwil3 dylwil3 deleted the bug/unpacking-tuple-exceptions branch July 24, 2024 14:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B013 false positive when using iterable unpacking in except clause
2 participants