Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid applying ignore-names to self and cls function names #12497

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Avoid applying ignore-names to self and cls function names #12497

merged 1 commit into from
Jul 24, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #12465.

@charliermarsh charliermarsh marked this pull request as ready for review July 24, 2024 21:31
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@zanieb
Copy link
Member

zanieb commented Jul 24, 2024

Makes sense and the ecosystem agrees!

@charliermarsh charliermarsh merged commit 2a64ccc into main Jul 24, 2024
20 checks passed
@charliermarsh charliermarsh deleted the charlie/n branch July 24, 2024 22:08
@BrewTestBot BrewTestBot mentioned this pull request Jul 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N804 and N805 apply ignore-names to function, rather than parameter names (self, cls)
2 participants
@charliermarsh @zanieb