Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[flake8-pytest-style] Improve help message for pytest-incorrect-mark-parentheses-style (PT023) #13092

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

calumy
Copy link
Contributor

@calumy calumy commented Aug 25, 2024

Summary

This PR updates the PT023 error to align with PT001, explicitly stating whether the parentheses need to be added or removed. Fixes #13010.

Test Plan

See updated snapshots

Copy link
Contributor

github-actions bot commented Aug 25, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood changed the title Fix inconsistent error messages between PT001 and PT023 [flake8-pytest-style] Improve help message for pytest-incorrect-mark-parentheses-style (PT023) Aug 26, 2024
@AlexWaygood AlexWaygood merged commit f50f873 into astral-sh:main Aug 26, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent error messages between PT001 and PT023
2 participants