Add time, tzinfo, and timezone as immutable function calls #13109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
datetime.datetime
,datetime.date
, anddatetime.timedelta
are correctly flagged as immutable calls, and RUF009 does not complain about their use in dataclasses. But thedatetime
module features three more classes that are also immutable:time
,tzinfo
, andtimezone
. See here for details. These are missing, and that causes a false positive for e.g. the following example:Test Plan
Not sure, I'm not all that familiar with Rust or the Ruff internals. How do I add tests for this? 😄