Don't skip over imports and other nodes containing nested statements in import collector #13521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up for #13441
enter_node
is called for every node and it's important that it returnstrue
for any node betweenModModule
and an import statement, including the import statement itself.Getting this right in
enter_node
seems hard and it's easy to forget adding a new "include" when a new compound statement gets added.This PR moves the traversal logic into the
visist_stmt
by requiring explicit match arms for each statement. I think this is easier to understandand less error prone.
Also...
enter_node
doesn't get call when a visitor overridesvisit_stmt
. That's an oversight from my side when designing the visitor.