Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[flake8-bugbear] Tweak B905 message to not suggest setting parameter strict= to False #13656

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

qdegraaf
Copy link
Contributor

@qdegraaf qdegraaf commented Oct 7, 2024

Summary

Tweaks the message of B905 to not contradict the B905 docs, leaves the autofix alone so as to avoid changing semantics or code behaviour. See also: #13581 (comment)

Test Plan

cargo test

Issue link

Closes: #13581

Copy link
Contributor

github-actions bot commented Oct 7, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 7, 2024 11:52
@AlexWaygood AlexWaygood added the rule Implementing or modifying a lint rule label Oct 7, 2024
@AlexWaygood AlexWaygood merged commit 646e413 into astral-sh:main Oct 7, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B905's autofix sets strict=False, but the suggested fix is strict=True
2 participants