Remove allow-unused-imports
setting from the common lint options
#13677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13668
Luckily, the
lint.allow_unused_imports
setting isn't read anywhere.However, this could still be considered a breaking change because Ruff might fail to read a previously valid configuration.
I do think that it should be very unlikely, considering that the configuration was "useless" before.
The setting remains available under
lint.pyflakes
ruff/crates/ruff_workspace/src/options.rs
Lines 2824 to 2829 in 0035ca9
Test Plan
cargo test