[pycodestyle
] Fix whitespace-related false positives and false negatives inside type-parameter lists
#13704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13699.
We had false positives and false negatives regarding whitespace in type-parameter lists, that led to conflicts between the linter and the formatter. Specifically, we emitted a false positive here:
and a false negative here:
This PR adds a
TypeParamsState
enum, to keep track of whether we're currently visiting theLogicalLineToken
s in a type parameters list or not. The common solution is then used to fix the bugs in both rules.Type parameter lists are new syntax that is only available in Python 3.13+, which is why this is only coming up now.
Test Plan
Fixtures have been added with examples of both class and function definitions that have type parameters