Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix await-outside-async to allow await at the top-level scope of a notebook #14225

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Nov 9, 2024

Summary

Fix await-outside-async to allow await at the top-level scope of a notebook.

# foo.ipynb

await asyncio.sleep(1)  # should be allowed

Test Plan

A unit test

Copy link
Contributor

github-actions bot commented Nov 9, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 71da1d6 into astral-sh:main Nov 9, 2024
20 checks passed
@charliermarsh charliermarsh added the bug Something isn't working label Nov 9, 2024
@charliermarsh
Copy link
Member

Thanks!

@harupy harupy deleted the fix-await-outside-async branch November 10, 2024 03:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants