Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove formatter incompatibility warning for ISC001 #15123

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Remove formatter incompatibility warning for ISC001 #15123

merged 1 commit into from
Jan 3, 2025

Conversation

MichaReiser
Copy link
Member

Summary

Remove the formatter incompatility warning from ISC001 because the formatter now:

  • Tries to join implicit concatenated strings that fit on a single line
  • Preserves implicit concatenated strings as mulitline for the few cases where the automatic-joining isn't supported

This PR adds a warning for lint.flake8-implicit-str-concat.allow-multiline = false if ISC001 is disabled.
This is not a new incompatibility, it's just that we forgot to add it.

Test Plan

See CLI tests

@MichaReiser MichaReiser force-pushed the micha/remove-isc001-warn branch from f9e0ebd to e777a2f Compare December 23, 2024 12:34
@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser marked this pull request as ready for review December 23, 2024 12:46
Base automatically changed from micha/ruff-2025 to ruff-0.9 January 3, 2025 13:16
@MichaReiser MichaReiser force-pushed the micha/remove-isc001-warn branch from e777a2f to aebcf27 Compare January 3, 2025 13:18
@MichaReiser MichaReiser merged commit f2f0ef7 into ruff-0.9 Jan 3, 2025
20 of 21 checks passed
@MichaReiser MichaReiser deleted the micha/remove-isc001-warn branch January 3, 2025 13:24
@MichaReiser MichaReiser mentioned this pull request Jan 3, 2025
Merged
2 tasks
MichaReiser added a commit that referenced this pull request Jan 8, 2025
@MichaReiser
Remove formatter incompatibility warning for ISC001 (#15123)
3e69e03
MichaReiser added a commit that referenced this pull request Jan 8, 2025
@MichaReiser
Remove formatter incompatibility warning for ISC001 (#15123)
b47398b
MichaReiser added a commit that referenced this pull request Jan 9, 2025
@MichaReiser
Remove formatter incompatibility warning for ISC001 (#15123)
b76d05e
@BrewTestBot BrewTestBot mentioned this pull request Jan 9, 2025
Merged
@notatallshaw notatallshaw mentioned this pull request Jan 10, 2025
Draft
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Jan 13, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @charliermarsh