-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[flake8-pyi
] Stabilize autofix for redundant-numeric-union
(PYI041
)
#15343
Conversation
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
PYI041 | 80 | 0 | 0 | 80 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
I just closed this as rejected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that we didn't add a test for the preview-only behaviour in #14273. But this all LGTM!
Agree. I think we did, but then gated the fix behind preview without creating a dedicated preview test. |
Summary
Stabilizes the autofix introduced in #14273
Test Plan
There are no open issues concerning this fix.
There are two open issues related to the rule:PYI041
considerbool
to be redundant withint
? #9810 asks to extend the rule to includebool
. This should not block stabilization because it's an extension of the ruleredundant-numeric-union
/PYI041
&redundant-literal-union
/PYI051
#14185 is the issue that requested adding this specific fix. This should definitely not block stabilization ;)