Directly include Settings struct for the server
#16042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
commented
Feb 8, 2025
Comment on lines
35
to
39
| if is_document_excluded_for_linting( | ||
| document_path, | ||
| file_resolver_settings, | ||
| &settings.file_resolver, | ||
| linter_settings, | ||
| query.text_document_language_id(), |
There was a problem hiding this comment.
I'm still passing these individually to is_document_excluded_* functions because some paths require a different linter settings (e.g., organize imports uses a specific settings which only selects I).
|
MichaReiser
approved these changes
Feb 9, 2025
dcreager
added a commit
that referenced
this pull request
Feb 10, 2025
* main: (991 commits) [red-knot] Resolve `Options` to `Settings` (#16000) Bump version to 0.9.6 (#16074) Revert tailwindcss v4 update (#16075) Improve migration document (#16072) Fix reference definition labels for backtick-quoted shortcut links (#16035) RUF009 should behave similar to B008 and ignore attributes with immutable types (#16048) [`pylint`] Also report when the object isn't a literal (`PLE1310`) (#15985) Update Rust crate rustc-hash to v2.1.1 (#16060) Root exclusions in the server to project root (#16043) Directly include `Settings` struct for the server (#16042) Update Rust crate clap to v4.5.28 (#16059) Update Rust crate strum_macros to 0.27.0 (#16065) Update NPM Development dependencies (#16067) Update Rust crate uuid to v1.13.1 (#16066) Update Rust crate strum to 0.27.0 (#16064) Update pre-commit dependencies (#16063) Update dependency ruff to v0.9.5 (#16062) Update Rust crate toml to v0.8.20 (#16061) [`flake8-builtins`] Make strict module name comparison optional (`A005`) (#15951) [`ruff`] Indented form feeds (`RUF054`) (#16049) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
RuffSettingsstruct to directly include the resolvedSettingsinstead of including the specific fields from it. The server utilizes a lot of it already, so it makes sense to just include the entire struct for simplicity.DerefI implemented
DerefonRuffSettingsto return theSettingsbecauseRuffSettingsis now basically a wrapper around it with the config path as the other field. This path field is only used for debugging ("printDebugInformation" command).