[red-knot] avoid inferring types if unpacking fails #16530
+67
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #15199.
The change I just made is to set all variables to type
Unknown
if unpacking fails, but in some cases this may be excessive.For example:
I will modify it if you think it would be better to make it a different type than just
Unknown
.Test Plan
I have made appropriate modifications to the test cases affected by this change, and also added some more test cases.