Fix can_omit_optional_parentheses
for expressions with a right most fstring
#9124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in our
can_omit_optional_parentheses
implementation.The goal of
can_omit_optional_parentheses
is to return true when the expression starts or ends with a parenthesized expression.However, our implementation incorrectly traversed into fstrings and other expressions that end with a token. We should skip these
(similar to other parenthesized expressions) because they're not at the end of the expression (they're wrapped).
A silly example, but it should do it for illustrating what it is about
Test Plan
Added test. The similarity for our old compatibility check remains unchanged. The ecosystem only shows one intentional change.