Fix dropped union expressions for piped non-types in PYI055 autofix
#9161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diceroll123
force-pushed
the
fix-pyi055
branch
3 times, most recently
from
baf7f95 to
76b0e36
Compare
diceroll123
force-pushed
the
fix-pyi055
branch
from
76b0e36 to
25d5ffa
Compare
|
diceroll123
changed the title
PYI055PYI055 autofix
| @@ -144,24 +147,32 @@ pub(crate) fn unnecessary_type_union<'a>(checker: &mut Checker, union: &'a Expr) | |||
| range: TextRange::default(), | |||
| })) | |||
There was a problem hiding this comment.
Do we not need to take the other_exprs into account in the top part of this if-else?
There was a problem hiding this comment.
I'll double-check!
diceroll123
force-pushed
the
fix-pyi055
branch
from
bd932b7 to
e88cd07
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix dropped union expressions for piped non-types in
PYI055autofixIf you had
type[int] | type[str] | str, it would have dropped thestr, which breaks the type!Closes #9156
Test Plan
cargo test