[flake8-bandit] Add S504 SslWithNoVersion rule
#9384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ use crate::registry::AsRule; | |||
| /// Checks for imports of the`telnetlib` module. | |||
| /// | |||
| /// ## Why is this bad? | |||
| /// Telnet is considered insecure. Instead, ise SSH or another encrypted | |||
| /// Telnet is considered insecure. Instead, use SSH or another encrypted | |||
charliermarsh
added
rule
|
Thanks for quick review! Unsure what's up with linux and windows tests, is this a known CI issue? |
charliermarsh
force-pushed
the
rule/S504
branch
from
5424691
to
51fb748
Compare
|
@qdegraaf - I think we just had to bump the rule set size. |
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
S504rule for the flake8-bandit plugin port.Checks for calls to
ssl.wrap_socketwhich have nossl_versionargument set. See also https://bandit.readthedocs.io/en/latest/_modules/bandit/plugins/insecure_ssl_tls.html#ssl_with_no_versionTest Plan
Fixture added
Issue Link
Refers: #1646