Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[docs] - Fix admonition hyperlink colouring #9385

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

Eutropios
Copy link
Contributor

Summary

Fix the colouration of hyperlinks within admonitions on dark theme to be more readable. Closes #9046

Test Plan

Documentation was regenerated via mkdocs and the supplied requirements.

Change colouring for admonition hyperlinks in dark theme to a more
readable colour

Signed-off-by: 64815328+Eutropios@users.noreply.github.com
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 4, 2024
@charliermarsh charliermarsh merged commit 1293383 into astral-sh:main Jan 4, 2024
16 checks passed
charliermarsh pushed a commit that referenced this pull request Jan 13, 2024
## Summary

The admonition in dark mode are in actually same as in light mode here:
https://docs.astral.sh/ruff/formatter/#ruff-format

I propose to move admonition in real dark mode as shown below:
- Before the PR #9385

![image](https://github.com/astral-sh/ruff/assets/45884742/abb7e0db-bf12-49cd-9f9b-e353accd571f)
- Current version

![image](https://github.com/astral-sh/ruff/assets/45884742/da8ab46d-dc87-412e-be2b-ac937cd87666)
- Proposal

![image](https://github.com/astral-sh/ruff/assets/45884742/7279cb02-e6af-4320-9dee-486fbfddcbc8)

Close #9501

## Test Plan

Documentation was regenerated via mkdocs and the supplied requirements.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad contrast for hyperlinks on note blocks in the webpage
2 participants