-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add docker files #323
base: main
Are you sure you want to change the base?
Add docker files #323
Conversation
Thanks for doing this! Now that I can take a closer look, I have a few questions:
|
|
|
Not sure if there is a definitive answer to this, it might depend on how you consider distributing astral with docker ? |
@unsync I could be totally off the mark but I assumed people who wanted Docker support mostly wanted it as a local dev tool. |
That is actually a very good question ! |
As originally stated in #212 I think the Docker image should be targeted at users who wish to self-host the application. I'm not too familiar with PHP applications but shouldn't the Docker image this application provides be using PHP-FPM for its entrypoint and allow the user to select the webserver of their choice to reverse proxy to traffic to the application container? Containing both a web server and application in one image is kind of a Docker anti-pattern IMO. |
@h1nk Thanks for chiming in, and in that case I believe you're right, the web server just shouldn't be part of the image. I don't know what changes would be required to create a good container for self-hosting, so I'm kinda leaning on the community here 😅 |
@h1nk your anti-pattern point is valid, yet the php-apache docker image is a fairly popular base image in the docker ecosystem, and nothing actually stops you from reverse-proxying from the current image (to use something like traefik in order to use you own https domain). My first goal was to have something simple to configure and more accessible for users (get traefik+mysql+astral in a docker-composer, and off you go). |
Hey, are people still interested in this? I personally would be, and I'd like to help I believe @h1nk is right about it being a Docker anti-pattern but it is definitely very helpful for people who run something as https://github.com/linuxserver/docker-swag and use it as their main entry point for all other containers. An example of this is the following Docker image https://github.com/itzg/docker-rcon-web-admin/blob/master/Dockerfile |
@obvionaoe Yes, I'd definitely still like to see an official Docker image for this project. Something that just runs php-fpm, exposes a TCP port and leaves it up to the user to setup |
if someone could help me understand how to run php-fpm in Docker I can do the rest of the work! I've tried running a lot of the php images and they always have some issues |
Agreed, I would love to see a php-fpm container but I think for new users a standalone container in the style of linuxservers.io or similar would be better, I'm using the cloud service atm but I'm anxious about affecting other users perf with my over 10k+ stars :P |
I didn't know that there are other people with more than 10k+ stars. (ref. maguowei/starred#116) Does Astral handle this amount well, also in the proposed container? The app.astralapp.com always loggs me out when fetching the initial list. It shouldn't be too hard to get a Compose going for a decoupled Nginx + PHP-FPM setup, very much like the one from Nextcloud. We only need to find a good Nginx template, that works well in accordance with the to be proposed Compose environment. |
Unfortunately in my testing it doesn't, it doesn't log me out but it just keeps increasing the amount of stars, way over the amount I had, it got to like 100k at one point and when I refreshed it reset |
Dear Astral's users, Although this post is old, I would like to know if the community has progressed with installing Astral through Docker. So far, I have not seen clear installation instructions for a non-skilled user like me. Nevertheless, there are four good attempts to install Astral with Docker: I would appreciate knowing if somebody could test Astral with Docker in 2024. |
I would appreciate knowing if somebody could test Astral with Docker in 2024. |
In response to #212