Major updates

[rnikutta]

The commit message:

• Rewrote and streamlined all queries to run in brief sync time. Using mydb in one case.
• No more need for static data files, deleted all.
• Redone much of query and bookkeeping logic to simplify workflows. Shorted the NB a lot.
• Renamed the ipynb file.
• Rewrote Goals and Intro.
• Cleaned up Imports.
• Updated figures and figure-making functions.
• Added docstrings to many functions.
• Added/rewrote/streamlined story-telling text across the NB.
• Synced TOCs with NB headings.

@kareninysimba @jacquesalice @bmerino95 can you please give this a review? If you only have minor comments, we can merge and feature this in the AAS Newsletter. If you find major issues, we'd have to push for a later release. Thank you!

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[rnikutta]

I just added to this PR: nbid.csv with this NB ID added (0068), and updated keywords.txt.

[kareninysimba]

Just a few corrections and non-critical suggestions on a very fast check:

1. In "Summary", change "currently under way on the CTIO Blanco 4m telescope" with "currently under way on the NOIRLab/Kitt Peak Mayall 4m telescope".

2. Adding the acronym after each survey would be helpful (DECaLS, BASS, MzLS) for people to recognize or look them up more quickly.

3. I would say, drop the ", including" from "...from the overview paper, including:" since that seems to imply you will next mention a few of the plots made in the notebook, not all of them, which is the case after the colon. Or, replace it with "which are".

4. Change "Fig 1: Query the catalogs..." with "Fig 2: Query the catalogs...".

5. In the first figure (Fig. 2) I wonder is there's a way to get a white background, much more desirable than dark grey. I noticed this is introduced by the masked_less_equal function on values=0 (and I didn't find a parameter to change it to white or none) which was done in order to eventually plot with a logarithmic scale, but we are not doing that here. Do you think that's necessary? Maybe commenting or removing that m_masked definition and plotting m instead of m_masked?

6. Typo: change "query that positinally JOINs" with "query that positionally joins".

7. Maybe the timeout=600 is not necessary any longer when defining dfx, since it went down to few seconds?

8. In plotting Fig. 8: I still prefer the look with nbins = 300 instead of 100, but I guess it's fine either way.

9. Typo: In Fig 15. first cell, change "which contai information" with "which contain information"
   (The way you shorten and made more efficient the process for Fig. 15 is remarkable. A lot to learn from it.)

10. In plotting Fig. 15, I would change 'violet' with 'purple'. That violet looks like a faint pink, gets too low of a profile in the plot compared to the other lines.

11. In first block of Fig 16: I would replace those ';' with ':' in the first sentence.

12. Typo: same block, replace "Finallu" with "Finally".

13. Typo: same block, replace "selectred" with "selected".

[rnikutta]

Thanks @kareninysimba , working on those now..

[rnikutta]

@kareninysimba Implemented and pushed all changes, except:

- In the first figure (Fig. 2) I wonder is there's a way to get a white background, much more desirable than dark grey. I noticed this is introduced by the masked_less_equal function on values=0 (and I didn't find a parameter to change it to white or none) which was done in order to eventually plot with a logarithmic scale, but we are not doing that here. Do you think that's necessary? Maybe commenting or removing that m_masked definition and plotting m instead of m_masked?

--> I was trying something that works in matplotlib:

from pylab import cm
cmap = cm.Blues
cmap.set_bad('white') # sets what color to use for bad/invalid/masked pixels

hp.projview(..., cmap=cmap, ...)

but alas it doesn't work in hp.projview yet. Removed the masked array part as per your suggestion.

- Maybe the timeout=600 is not necessary any longer when defining dfx, since it went down to few seconds?

--> I've been running the queries many many times over the past few days, and when the machines/services were busy, the runtime could grow quite a bit. Let's leave the timeout at 600 just in case.

- In plotting Fig. 8: I still prefer the look with nbins = 300 instead of 100, but I guess it's fine either way.

--> With 300, the relation gets very tight, and one doesn't see the smeared-out broader distribution. Decided to keep it at 100.

- In plotting Fig. 15, I would change 'violet' with 'purple'. That violet looks like a faint pink, gets too low of a profile in the plot compared to the other lines.

--> Purple looks so close to both red and blue. How about a compromise of "awesome orange"?

[kareninysimba]

Sounds good. I try it and awesome orange seems fine :)

[kareninysimba]

I still see the semicolons in the first paragraph of Fig. 16 section (last plot). I still think is better to replace them with colons, i.e. change
...EXP (exponential disk; spiral galaxies), or DEV (de Vaucouleurs profile; elliptical galaxies)
with
...EXP (exponential disk: spiral galaxies), or DEV (de Vaucouleurs profile: elliptical galaxies)
Semicolon is eventually to separate ideas/sentences more or less semi-related or unrelated
You can also use "i.e." to replace the ";"

[bmerino95]

Hi all! This notebook looks really good. I didn't get any errors running it, I verified that all the links work, and the code looks solid. I only found a few spelling/grammar mistakes. Here is my feedback for DESILegacySurveys.ipynb:

1. In summary:

• 'under way' should be one word
• '14,000 squere degrees' should be '14,000 square degrees'
• Change 'g, r, z bands' to 'g, r, and z bands'

2. In the markdown cell Fig15:

• This sentence:
  • Now we are going to calculate the depth for point sources in DRs 6, 7, and 9, for each band g,r,z following the prescription in the original paper.
• can be rewritten like so:
  • Now, we will calculate the depth for point sources in DRs 6, 7, and 9 for each band g,r,z following the prescription in the original paper.

[rnikutta]

Thank you @bmerino95 , I implemented your comments. Please approve and I'll merge.

[bmerino95]

The notebook looks good, and I have verified that the changes have been made.

[rnikutta]

Thank you @bmerino95 , merging!

[kareninysimba]

🎉🕺🏻🎊🕺🏻🎈🕺🏻