Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added the death animations #178

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Added the death animations #178

merged 3 commits into from
Jan 17, 2023

Conversation

EthanHair
Copy link
Contributor

Added the death animations for the troll and goblin

closes #174

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-forest-044727f10-178.centralus.2.azurestaticapps.net

@Psypher9 Psypher9 self-requested a review January 16, 2023 22:34
@Psypher9
Copy link
Member

I'm seeing that we might benefit from having an Enemy node to contain some of the duplicate code. It looks like The Goblin and Troll nodes would inherit from that type and have their stats and sprites tweaked a bit. What do you think?

@EthanHair
Copy link
Contributor Author

Can we do class inheritance like that in gdscript?

@Psypher9
Copy link
Member

Yeah we can, any time we add a script to a Node, it's actually extending the type of that Node. That's why when we add a Script to a Node for an Area or a Kinematic body, we can use those signals.

@EthanHair
Copy link
Contributor Author

Lol yeah I just realized that's how all the nodes work. Yeah I can work on making that change

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-forest-044727f10-178.centralus.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-forest-044727f10-178.centralus.2.azurestaticapps.net

@EthanHair EthanHair mentioned this pull request Jan 17, 2023
Merged
@EthanHair EthanHair merged commit 290581b into main Jan 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@caldane caldane caldane approved these changes

@Psypher9 Psypher9 Awaiting requested review from Psypher9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enemy death animation
3 participants
@EthanHair @Psypher9 @caldane