Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update contributor docs #1110

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Update contributor docs #1110

merged 2 commits into from
Nov 21, 2023

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Nov 21, 2023

Some comments on the PRs/issues resulting from the recent conference brought to my attention that the developer docs are very out of date. Hopefully this update will be more useful to new contributors.

@rosteen rosteen requested a review from kelle November 21, 2023 15:20
@rosteen rosteen added the docs label Nov 21, 2023
@rosteen rosteen added this to the v1.x milestone Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8707443) 70.73% compared to head (fe32978) 70.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   70.73%   70.74%           
=======================================
  Files          64       64           
  Lines        4483     4484    +1     
=======================================
+ Hits         3171     3172    +1     
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments/have some questions.

docs/contributing.rst Show resolved Hide resolved
docs/contributing.rst Show resolved Hide resolved
@kelle kelle self-requested a review November 21, 2023 21:36
Copy link
Member

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time I make changes, I'll test all this out, but for the moment, this looks like great progress! Thanks!

@rosteen rosteen merged commit fd48630 into astropy:main Nov 21, 2023
10 of 11 checks passed
rosteen added a commit to rosteen/specutils that referenced this pull request Nov 29, 2023
* Add tox to test install deps, updating contributor docs

* Clean up a couple other things
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants