Add option to have inclusive upper boundaries in fitting/excision. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inclusive upper bounds (so the upper bound is...excluded)
rosteen
added
feature
fitting
This was referenced Sep 24, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 86.87% 86.84% -0.04%
==========================================
Files 63 63
Lines 4549 4553 +4
==========================================
+ Hits 3952 3954 +2
- Misses 597 599 +2 ☔ View full report in Codecov by Sentry. |
|
Test failures are unrelated, I'm going to go ahead and merge. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1168 by making this behavior an optional toggle in
fit_models,fit_continuum, andexcise_regionsrather than changing the default.Closes #1167.