Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement reader for REDUCE files, superceeds #14 #17

Closed
wants to merge 1 commit into from

Conversation

hamogu
Copy link
Member

@hamogu hamogu commented Mar 15, 2013

As suggested by @wkerzendorf, I split the old pull request #14. This is the REDUCE part.

@hamogu hamogu mentioned this pull request Mar 15, 2013
@hamogu
Copy link
Member Author

hamogu commented Apr 3, 2013

@wkerzendorf Since the master has changed again after merging #20, I would have to rebase and modify my readers (This and issues #16 and #18) again. However, before I do that I would like your opinion about them - if you think we should not have these capabilities yet because the Spectrum1D API is not stable yet, then I'll save that time.
I already invested some time in rebasing them after you asked me to split #14 into separate pull requests; I fully understand if you want to wait until after the API document is there, but if that is the case then I won't spend any time on them either.

@wkerzendorf
Copy link
Member

@hamogu: I'm currently working on the API (as in right now) - wait a little bit. I should have something by this afternoon/evening.


from astropy.io import fits
from astropy.nddata.nduncertainty import StdDevUncertainty
from specutils.spectrum1d import Spectrum1D
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a relative import

@hamogu
Copy link
Member Author

hamogu commented Apr 7, 2013

Unfortunately, this will need to wait a little longer. In the current implementation, dispersion and flux can no longer be 2-dim arrays. We'll need a Spectra1DEchelle object or something like that. That's discussed in depth in #11, and will probably only be decided after we have an API document out there.

@wkerzendorf
Copy link
Member

Superseded by @shaileshahuja implementation

keflavich pushed a commit to keflavich/specutils that referenced this pull request Sep 21, 2017
Use Cookiecutter for the package-template (APE 12)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants