Makes using shouldExpand with uneven tabs work correctly #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silentnuke-old
added a commit
to silentnuke-old/PagerSlidingTabStriptest
that referenced
this pull request
Jun 27, 2014
axsddlr
added a commit
to AOSPA-legacy/android_packages_apps_Settings
that referenced
this pull request
Jul 9, 2014
-- Check if tabCount > 0 (do this before attempting tabsContainer.getChildAt(position) when scrolling to child.) -- if pager == null no need to call requestLayout() -- make shouldExpand work correctly (referenced here: astuetz/PagerSlidingTabStrip#42) -- Use Gravity to center tabs -- add onTabReselected() callbackFunction ( referenced here: astuetz/PagerSlidingTabStrip#92) Change-Id: I0184de3c010a902a721572d3dcaa75101e38aa0c Signed-off-by: Andre Saddler <dresadd09691@gmail.com>
axsddlr
added a commit
to AOSPA-legacy/android_packages_apps_Settings
that referenced
this pull request
Jul 9, 2014
-- Check if tabCount > 0 (do this before attempting tabsContainer.getChildAt(position) when scrolling to child.) -- if pager == null no need to call requestLayout() -- make shouldExpand work correctly (referenced here: astuetz/PagerSlidingTabStrip#42) -- Use Gravity to center tabs -- add onTabReselected() callbackFunction (referenced here: astuetz/PagerSlidingTabStrip#92) -- Fix: Tab dislocation caused by setViewPager Change-Id: I0184de3c010a902a721572d3dcaa75101e38aa0c Signed-off-by: Andre Saddler <dresadd09691@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current implementation using shouldExpand="true" with tabs that aren't of the same width may result in cropping longer tab labels.
This is due to setting
layout params for every tab whenever the tabs are expanded to fill the whole screen width.
This fix gets weight from the width of the tab:
during the fitting. Thanks to that, the tabs retain their previous proportions.
Current behaviour:
After applying this fix: