-
Notifications
You must be signed in to change notification settings - Fork 339
expose std::sync::atomic #355
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
What if we just did |
@stjepang I did that, and it also exposes all the deprecated items. Figured this may look a bit cleaner (: |
What if an architecture has some atomics (e.g. AtomicU64 on 32-bit platforms) missing? |
I'm a bit on the fence here. My impression is that atomics are not very common in async code and are kind of low-level (memory orderings, how do they work?) so I don't know if they belong into |
@stjepang I tend to err on the side of "eh, let's add it" if it directly re-exports a part of std in an existing submodule. I wanted to port std's docs, which talk about Atomics a bunch so figured we might as well export them 😅 |
FYI: #286 fixes that issue. |
I personally prefer to only include things that are related to async code. Also, |
I don't feel too strongly about this anymore. I'm fine to close this. |
This exposes
async_std::sync::atomic
. If we want to document thesync
submodule similar to std, we will need to expose this. I feel it's also nice to continue to move towards parity with std.Thanks!