Skip to content

Test and fix 32 bit targets #756

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2020
Merged

Test and fix 32 bit targets #756

merged 5 commits into from
May 7, 2020

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Apr 26, 2020 •
edited
Loading

Based on #286

Closes #141,#664

@dignifiedquire
Copy link
Member Author

Due to the fact that Mutex::new is not a const function, the fallback failed for now. Switching to AtomicUsize. If someone has a better fix please PR it :) But this at least unblocks these systems for a while

@bltavares
Copy link

❤️ This changeset allowed me to compile async-std on MIPS (should close #664 also)

@dignifiedquire dignifiedquire force-pushed the fix-atomic-32 branch 2 times, most recently from dd0e8b8 to 713b540 Compare May 7, 2020 19:23
@dignifiedquire dignifiedquire changed the title [WIP] Test and fix 32 bit targets Test and fix 32 bit targets May 7, 2020
@dignifiedquire dignifiedquire mentioned this pull request May 7, 2020
Merged
@dignifiedquire dignifiedquire merged commit e4c4c93 into master May 7, 2020
@dignifiedquire dignifiedquire deleted the fix-atomic-32 branch May 7, 2020 21:20
@bltavares bltavares mentioned this pull request May 19, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dignifiedquire @bltavares @taiki-e