fix(fs): use smol::block_on for drop handling of File #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2020
|
I'd like to suggest having: |
0x8f701
pushed a commit
to 0x8f701/casbin-rs
that referenced
this pull request
May 9, 2020
yoshuawuyts
approved these changes
May 9, 2020
0x8f701
added a commit
to casbin/casbin-rs
that referenced
this pull request
May 10, 2020
* upgrade async-std to 1.6 beta * add ip feature * add glob feature * add cacehd feature * fix runtime-tokio clippy warnings * add watcher feature * don't clone if watcher feature has been disabled * use async-rs/async-std#768 for fixing tests * activate all features for bench test over previous version * benchmark pull_request and decrease the threshold * switch to github actions * fix typo * Fix: cargo test features doesn't like space * better management of feature:logging and feature:watcher * use async-std/master for testing * add basic wasm32 support * use runtime-async-std for wasm32 test * fix clippy warnings * fix typo * make other tests avalaible only on no-wasm32 target * finish split code into features && bump version
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids nesting of
task::block_oncalls.Ref #766