Stabilize Future adapters and IntoFuture #884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
force-pushed
the
stabilize-future-extensions
branch
from
2df9428 to
f867373
Compare
|
CI is failing because of #883 |
|
Btw, should we switch to libstd's IntoFuture or would that be breaking? |
taiki-e
reviewed
Sep 24, 2020
| @@ -47,8 +47,11 @@ | |||
| //! [`Future::try_race`]: trait.Future.html#method.try_race | |||
|
|
|||
| cfg_alloc! { | |||
| pub use into_future::IntoFuture; | |||
There was a problem hiding this comment.
If you plan to replace this with re-export of std IntoFuture when std IntoFuture's is stable, that would be a breaking change. IIUC, theoretically, there is a way to avoid almost breakage. See rust-lang/futures-rs#2207 and https://github.com/taiki-e/futures-compat-experiment for that.
|
@yoshuawuyts these CI failures look somewhat real to me |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilizes several stream adapters that have been proven over the last year. Also stabilizes
IntoFuture. Thanks!Changelog