Skip to content

remove deprecated sync::channel #933

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

remove deprecated sync::channel #933

merged 1 commit into from
Jan 15, 2021

Conversation

dignifiedquire
Copy link
Member

No description provided.

Keruspe
Keruspe approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@Keruspe Keruspe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

What about stabilizing the new channels?

@dignifiedquire
Copy link
Member Author

What about stabilizing the new channels?

I thought it would be cleaner to do it in its own PR

@dignifiedquire dignifiedquire merged commit b1b8355 into master Jan 15, 2021
@dignifiedquire dignifiedquire deleted the remove-old-channel branch January 15, 2021 08:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Keruspe Keruspe Keruspe approved these changes

@yoshuawuyts yoshuawuyts Awaiting requested review from yoshuawuyts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @Keruspe