Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: refactor library to prepare for v3 #179

Merged
merged 15 commits into from
Jun 20, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jun 13, 2023

Description
This PR takes all the unrelated v3 structural changes from #163 and adds them to a single PR to make the v3 changes easier to review down the line.

All changes are mainly done by @magicmatatjahu, I just clean it up and adapt it to any review comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@jonaslagoni
Copy link
Member Author

Pretty sure this is just a refactoring without adapting or changing the API of the library nor the underlying converter functionality.

Thats why I am using chore.

@jonaslagoni jonaslagoni changed the title chore: update structure to prepare for v3 chore: refactor library to prepare for v3 Jun 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

Whenever you get some time @fmvilas, think you are the only codeowner that's currently available 😄

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm although with such large refactors I personally always prefer to trigger release to learn early that something is broken 😄 feel free to change to fix:

@jonaslagoni jonaslagoni changed the title chore: refactor library to prepare for v3 fix: refactor library to prepare for v3 Jun 20, 2023
@jonaslagoni
Copy link
Member Author

Why not 😄

@jonaslagoni jonaslagoni requested a review from derberg June 20, 2023 13:39
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 1155c51 into asyncapi:master Jun 20, 2023
@jonaslagoni jonaslagoni deleted the update_structure branch June 21, 2023 12:53
@jonaslagoni jonaslagoni mentioned this pull request Jun 22, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants