-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: refactor library to prepare for v3 #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Pretty sure this is just a refactoring without adapting or changing the API of the library nor the underlying converter functionality. Thats why I am using |
Kudos, SonarCloud Quality Gate passed!
|
Whenever you get some time @fmvilas, think you are the only codeowner that's currently available 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm although with such large refactors I personally always prefer to trigger release to learn early that something is broken 😄 feel free to change to fix:
Why not 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/rtm |
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR takes all the unrelated v3 structural changes from #163 and adds them to a single PR to make the v3 changes easier to review down the line.
All changes are mainly done by @magicmatatjahu, I just clean it up and adapt it to any review comments