feat: additional changes for implementation of new preview command #1167
Conversation
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
@Shurtu-gal can you please have a look at the mentioned approach and changes. If all good then will proceed with this. Thanks. |
|
@Shurtu-gal any update on this? |
|
Some other things also maybe need to be changed, like removing other views etc. Have you tested it out? |
|
Actually no i haven't tested it out yet but have below 2 approaches for the same:- As mentioned this change will only affect the implementation of Or one other way could be to test websockets via sending requests through postman or something. @Shurtu-gal Let me know your thoughts on above mentioned approaches and would be testing based on that and if some other way is also possible please guide. Thanks. |
|
The first one is preferable. You can change package json to point to locally changed repo and start from there. |
Okay, will proceed with same. |
|
@Shurtu-gal was trying to build the studio and linking it to cli for testing but after the build for studio is complete i am not able to understand which folder form It would be very helpful to me if you could provide some guidance on these issues for me to test this implementation. Thanks. |
Description
This PR introduces the necessary changes for implementation of
readOnlymode in studio when used withasyncapi start previewcommand.Approach :-
An additional message can be sent through websocket upon initialization which will set the app state to
readOnly. As this is being done internally only through theasyncapi start previewcommand hence in all other cases will remain as it is and if used outside theasyncapi start previewcommand thereadOnlyparameter will only work with eitherurlorbase64string or share and no websocket connection will be established in those cases.Related issue(s)
Resolves #1166