Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/attendances #35

Merged
merged 40 commits into from
Mar 24, 2023
Merged

Feature/attendances #35

merged 40 commits into from
Mar 24, 2023

Conversation

fatemetardasti96
Copy link
Contributor

Checklist for your PR

  • please start with a draft PR and mark it as ready for review when you are confident that your implementation works as expected.
  • add a changelog entry in CHANGELOG.md with a link to this PR.
  • make sure that all tests pass and add new test functions if your code is not covered by existing tests. Please use mock tests when network requests are required.
  • let someone review & approve your code, make changes where necessary.

Hints

  • name your branches accordingly: use the prefixes bugfix/, feature/, or release/ and then a short title for your PR in kebab-case (lowercase words separated with dashes), e.g. feature/my-awesome-feature.
  • Please make sure that pre-commit hooks are enabled on your system to avoid common mistakes before you make a commit.
  • feel free to delete this template and replace it with your own description of the PR.

Philip Flohr and others added 30 commits November 30, 2020 11:51
Add basic raw api test
…d in multiple files (#11)

* Place authentication in importable file for use with test cases placed in multiple files

* Readd existing tests

* Update import statement

* Don't use shared_test_data dict, cache retrieval of valid online user

* Don't require python3.8 to run the tests

* cleanup

Co-authored-by: Sebastian Straub <sebastian.straub@alexanderthamm.com>
…k_client , set attendance client upon retrieval
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage: 88.15% and project coverage change: +0.66 🎉

Comparison is base (3cd11f6) 86.71% compared to head (29e60bd) 87.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   86.71%   87.37%   +0.66%     
==========================================
  Files           7        7              
  Lines         843      895      +52     
==========================================
+ Hits          731      782      +51     
- Misses        112      113       +1     
Impacted Files Coverage Δ
src/personio_py/models.py 90.49% <85.71%> (+0.61%) ⬆️
src/personio_py/client.py 81.81% <88.88%> (+2.35%) ⬆️
src/personio_py/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@klamann klamann mentioned this pull request Mar 16, 2023
Copy link
Contributor

@klamann klamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you for your contribution @fatemetardasti96!

@klamann klamann merged commit d2478be into master Mar 24, 2023
@klamann klamann deleted the feature/attendances branch March 24, 2023 16:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants