Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Contents of done() console.log'd out #2

Closed
Snugug opened this issue Mar 14, 2015 · 8 comments
Closed

Contents of done() console.log'd out #2

Snugug opened this issue Mar 14, 2015 · 8 comments

Comments

@Snugug
Copy link
Member

Snugug commented Mar 14, 2015

When run successfully, the object passed to done() gets console.log'd out, even without me doing so. Not sure if it's related to gulp-sass or node-sass

@Snugug
Copy link
Member Author

Snugug commented Mar 14, 2015

@akhleung @am11 @andrew @dlmanning thoughts on why this may be happening?

@Snugug
Copy link
Member Author

Snugug commented Mar 14, 2015

@Jakobo @chriseppstein too

@am11
Copy link

am11 commented Mar 14, 2015

@Snugug, that was due to sass/node-sass#615. A temporary hack which is supposed to be fixed in v3 stable.

BTW, you can search node-sass issue tracker to figure out this kind of thing..

@Snugug
Copy link
Member Author

Snugug commented Mar 14, 2015

Didn't quite know what I was looking for there, haven't seen many people doing things with custom importers. Thanks!

@Snugug Snugug closed this as completed Mar 14, 2015
@thecodedrift
Copy link

As an aside, the code as written also has some issues. Since the importedFiles is loaded once for the module, multiple calls to node-sass with this importer will reuse the object literal.

This is a known bug in eyeglass. The addition of a context object (v3) should make it possible to maintain a per-render cache inside of the this keyword. It'll actually trip you up in any build pipeline, since gulp/grunt/broccoli/etc just reuse the same options file each time.

function importer(uri, prev, done) {
  var isRealFile = fs.existsSync(prev),
      file;
  // new!
  if (!this._importOnceCache) {
    this._importOnceCache = {};
  }
  // ...

@Snugug
Copy link
Member Author

Snugug commented Mar 14, 2015

Ooo, like. I was just running simple things trying to get a basic version of this out, but I'll circle back to that. Thanks!

@andrew
Copy link

andrew commented Mar 14, 2015

@Snugug there's no need to mention everyone involved, anyone who's watching the repo will get an email about new issues and comments.

@Snugug
Copy link
Member Author

Snugug commented Mar 14, 2015

Yah, my brain wasn't functioning last night when I wrote those issues, sorry about that. Thought I would as no one was watching this repo at the time.

On Mar 14, 2015, at 4:41 AM, Andrew Nesbitt notifications@github.com wrote:

@Snugug there's no need to mention everyone involved, anyone who's watching the repo will get an email about new issues and comments.


Reply to this email directly or view it on GitHub.

Snugug added a commit that referenced this issue Mar 16, 2015
Via suggestion by @Jakobo in #2
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants