Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Install golangci-lint from fork using dev branch #1591

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jun 26, 2024

Use dev feat/go1.23 branch from golangci-lint fork in unstable linting image until complete support lands in official repo.

fixes GH-1590

Use dev feat/go1.23 branch from golangci-lint fork in unstable
linting image until complete support lands in official repo.

refs GH-1590
@atc0005 atc0005 added this to the Next Release milestone Jun 26, 2024
@atc0005 atc0005 self-assigned this Jun 26, 2024
- v1.59.1 for stable, oldstable images
- feat/go1.23 dev branch for unstable image

Other minor formatting/language tweaks for linter tables.

refs GH-1590
@atc0005 atc0005 added the documentation Improvements or additions to documentation label Jun 26, 2024
@atc0005 atc0005 merged commit 6b7418a into master Jun 26, 2024
20 checks passed
@atc0005 atc0005 deleted the i1590-switch-golangci-lint-source branch June 26, 2024 11:08
atc0005 added a commit that referenced this pull request Jun 26, 2024
Missed this when prepping changes for GH-1591.
atc0005 added a commit that referenced this pull request Aug 7, 2024
Instead of silently using the very latest commit from the
`feat/go1.23` branch on the fork use a fixed tag to make
it easier to track when unstable golangci-lint builds are
updated.

refs GH-1591
atc0005 added a commit that referenced this pull request Aug 7, 2024
Update fixed tag from `2024-07-18` to `2024-07-31` to pull in the
latest Go 1.23 support changes.

refs GH-1591
refs GH-1657
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working dependencies documentation Improvements or additions to documentation linting unstable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint unusable within Go 1.23 pre-release images
1 participant