Process all images when building #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the `build` Makefile recipe build legacy mirror images in addition to all other images. This adds to the build time, but helps ensure that all images are uploaded and that the (newly created) `go-ci-oldstable-mirror-build` and `go-ci-stable-mirror-build` image tags are maintained as intended. If all goes as planned then the legacy images will grow additional versioned tags over time, but the layers for the images will *not* continue to grow (as the upstream images are unmaintained, but still provided as-is). Drop separate workflow job step to handle building legacy images now that the `build` recipe also triggers legacy image builds. refs GH-847
atc0005
added
documentation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
buildMakefile recipe build legacy mirror images in addition to all other images. This adds to the build time, but helps ensure that all images are uploaded and that the (newly created)go-ci-oldstable-mirror-buildandgo-ci-stable-mirror-buildimage tags are maintained as intended.If all goes as planned then the legacy images will grow additional versioned tags over time, but the layers for the images will not continue to grow (as the upstream images are unmaintained, but still provided as-is).
Drop separate workflow job step to handle building legacy images now that the
buildrecipe also triggers legacy image builds.refs GH-847